fix(router): fix return value for getTransition of NSRouterLink #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return undefined transition value from getTransition method of NSRouterLink when boolean value is used for pageTransition input. Closes #1784
ghost
added
VladimirAmiorkov
approved these changes
May 3, 2019
|
Any news on this PR? |
|
Hi @flore2003 , The PR has been reviewed but is not yet merged because we are in the process of a release which is planned for later this week. After that release we will update this PR to the latest branch and process it. Sorry for the delay caused by our current release plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return undefined transition value from getTransition method of NSRouterLink when boolean value is used for pageTransition input. Fixes #1784
PR Checklist
What is the current behavior?
The
getTransitionmethod ofNSRouterLinkreturns an empty object value for the transition property, when the ´pageTransition´ input is given a boolean value. This leads to the defaultTransition of the Frame not being applied.What is the new behavior?
The
getTransitionmethod ofNSRouterLinknow returns undefined as the value for the transition property.Fixes #1784.